add CacheManagerInterface.php that will allow CacheManager.php to be …#1351
add CacheManagerInterface.php that will allow CacheManager.php to be …#1351
Conversation
|
can you remove all the formatting changes from the PR? |
|
Don't remember - I think I decided to go with Adapter Pattern in my case, but I think it's useful anyway. :) |
|
Basically I needed to add if(stripos($path, 'XXX') !== false) {
$runtimeConfig['YY'] = ['xxx' => 'xxx']
}
return $this->decorated->getBrowserPath($path, $filter, $runtimeConfig.... );` |
|
ok .. as long as there is a use-case I am fine adding an interface :) |
|
The The first one, for the The second one, for the I see here a nice opportunity to split The code is quite complex, but I would start with introducing some kind of |
|
i like the suggestion of @fbourigault - do you want to split the interface in the way he suggested @Warxcell ? |
…decorated.